Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 8de62f1a8f991f900fd1482f64976f234011f4d2 Co-authored-by: xinhuagu <562450+xinhuagu@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky
158 lines
5.1 KiB
TypeScript
158 lines
5.1 KiB
TypeScript
import { describe, expect, it, vi } from "vitest";
|
|
import type { RuntimeEnv } from "../runtime.js";
|
|
|
|
const mocks = vi.hoisted(() => ({
|
|
text: vi.fn(),
|
|
select: vi.fn(),
|
|
confirm: vi.fn(),
|
|
resolveGatewayPort: vi.fn(),
|
|
buildGatewayAuthConfig: vi.fn(),
|
|
note: vi.fn(),
|
|
randomToken: vi.fn(),
|
|
}));
|
|
|
|
vi.mock("../config/config.js", async (importActual) => {
|
|
const actual = await importActual<typeof import("../config/config.js")>();
|
|
return {
|
|
...actual,
|
|
resolveGatewayPort: mocks.resolveGatewayPort,
|
|
};
|
|
});
|
|
|
|
vi.mock("./configure.shared.js", () => ({
|
|
text: mocks.text,
|
|
select: mocks.select,
|
|
confirm: mocks.confirm,
|
|
}));
|
|
|
|
vi.mock("../terminal/note.js", () => ({
|
|
note: mocks.note,
|
|
}));
|
|
|
|
vi.mock("./configure.gateway-auth.js", () => ({
|
|
buildGatewayAuthConfig: mocks.buildGatewayAuthConfig,
|
|
}));
|
|
|
|
vi.mock("../infra/tailscale.js", () => ({
|
|
findTailscaleBinary: vi.fn(async () => undefined),
|
|
}));
|
|
|
|
vi.mock("./onboard-helpers.js", async (importActual) => {
|
|
const actual = await importActual<typeof import("./onboard-helpers.js")>();
|
|
return {
|
|
...actual,
|
|
randomToken: mocks.randomToken,
|
|
};
|
|
});
|
|
|
|
import { promptGatewayConfig } from "./configure.gateway.js";
|
|
|
|
function makeRuntime(): RuntimeEnv {
|
|
return {
|
|
log: vi.fn(),
|
|
error: vi.fn(),
|
|
exit: vi.fn(),
|
|
};
|
|
}
|
|
|
|
async function runGatewayPrompt(params: {
|
|
selectQueue: string[];
|
|
textQueue: Array<string | undefined>;
|
|
randomToken?: string;
|
|
confirmResult?: boolean;
|
|
authConfigFactory?: (input: Record<string, unknown>) => Record<string, unknown>;
|
|
}) {
|
|
vi.clearAllMocks();
|
|
mocks.resolveGatewayPort.mockReturnValue(18789);
|
|
mocks.select.mockImplementation(async () => params.selectQueue.shift());
|
|
mocks.text.mockImplementation(async () => params.textQueue.shift());
|
|
mocks.randomToken.mockReturnValue(params.randomToken ?? "generated-token");
|
|
mocks.confirm.mockResolvedValue(params.confirmResult ?? true);
|
|
mocks.buildGatewayAuthConfig.mockImplementation((input) =>
|
|
params.authConfigFactory ? params.authConfigFactory(input as Record<string, unknown>) : input,
|
|
);
|
|
|
|
const result = await promptGatewayConfig({}, makeRuntime());
|
|
const call = mocks.buildGatewayAuthConfig.mock.calls[0]?.[0];
|
|
return { result, call };
|
|
}
|
|
|
|
async function runTrustedProxyPrompt(params: {
|
|
textQueue: Array<string | undefined>;
|
|
tailscaleMode?: "off" | "serve";
|
|
}) {
|
|
return runGatewayPrompt({
|
|
selectQueue: ["loopback", "trusted-proxy", params.tailscaleMode ?? "off"],
|
|
textQueue: params.textQueue,
|
|
authConfigFactory: ({ mode, trustedProxy }) => ({ mode, trustedProxy }),
|
|
});
|
|
}
|
|
|
|
describe("promptGatewayConfig", () => {
|
|
it("generates a token when the prompt returns undefined", async () => {
|
|
const { result } = await runGatewayPrompt({
|
|
selectQueue: ["loopback", "token", "off"],
|
|
textQueue: ["18789", undefined],
|
|
randomToken: "generated-token",
|
|
authConfigFactory: ({ mode, token, password }) => ({ mode, token, password }),
|
|
});
|
|
expect(result.token).toBe("generated-token");
|
|
});
|
|
|
|
it("does not set password to literal 'undefined' when prompt returns undefined", async () => {
|
|
const { call } = await runGatewayPrompt({
|
|
selectQueue: ["loopback", "password", "off"],
|
|
textQueue: ["18789", undefined],
|
|
randomToken: "unused",
|
|
authConfigFactory: ({ mode, token, password }) => ({ mode, token, password }),
|
|
});
|
|
expect(call?.password).not.toBe("undefined");
|
|
expect(call?.password).toBe("");
|
|
});
|
|
|
|
it("prompts for trusted-proxy configuration when trusted-proxy mode selected", async () => {
|
|
const { result, call } = await runTrustedProxyPrompt({
|
|
textQueue: [
|
|
"18789",
|
|
"x-forwarded-user",
|
|
"x-forwarded-proto,x-forwarded-host",
|
|
"nick@example.com",
|
|
"10.0.1.10,192.168.1.5",
|
|
],
|
|
});
|
|
|
|
expect(call?.mode).toBe("trusted-proxy");
|
|
expect(call?.trustedProxy).toEqual({
|
|
userHeader: "x-forwarded-user",
|
|
requiredHeaders: ["x-forwarded-proto", "x-forwarded-host"],
|
|
allowUsers: ["nick@example.com"],
|
|
});
|
|
expect(result.config.gateway?.bind).toBe("loopback");
|
|
expect(result.config.gateway?.trustedProxies).toEqual(["10.0.1.10", "192.168.1.5"]);
|
|
});
|
|
|
|
it("handles trusted-proxy with no optional fields", async () => {
|
|
const { result, call } = await runTrustedProxyPrompt({
|
|
textQueue: ["18789", "x-remote-user", "", "", "10.0.0.1"],
|
|
});
|
|
|
|
expect(call?.mode).toBe("trusted-proxy");
|
|
expect(call?.trustedProxy).toEqual({
|
|
userHeader: "x-remote-user",
|
|
// requiredHeaders and allowUsers should be undefined when empty
|
|
});
|
|
expect(result.config.gateway?.bind).toBe("loopback");
|
|
expect(result.config.gateway?.trustedProxies).toEqual(["10.0.0.1"]);
|
|
});
|
|
|
|
it("forces tailscale off when trusted-proxy is selected", async () => {
|
|
const { result } = await runTrustedProxyPrompt({
|
|
tailscaleMode: "serve",
|
|
textQueue: ["18789", "x-forwarded-user", "", "", "10.0.0.1"],
|
|
});
|
|
expect(result.config.gateway?.bind).toBe("loopback");
|
|
expect(result.config.gateway?.tailscale?.mode).toBe("off");
|
|
expect(result.config.gateway?.tailscale?.resetOnExit).toBe(false);
|
|
});
|
|
});
|