649826e435
* fix(security): block private/loopback/metadata IPs in link-understanding URL detection isAllowedUrl() only blocked 127.0.0.1, leaving localhost, ::1, 0.0.0.0, private RFC1918 ranges, link-local (169.254.x.x including cloud metadata), and CGNAT (100.64.0.0/10) accessible for SSRF via link-understanding. Add comprehensive hostname/IP blocking consistent with the SSRF guard already used by media/fetch.ts. * fix(security): harden link-understanding SSRF host checks * fix: note link-understanding SSRF hardening in changelog (#15604) (thanks @AI-Reviewer-QS) --------- Co-authored-by: Yi LIU <yi@quantstamp.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>
67 lines
2.8 KiB
TypeScript
67 lines
2.8 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { extractLinksFromMessage } from "./detect.js";
|
|
|
|
describe("extractLinksFromMessage", () => {
|
|
it("extracts bare http/https URLs in order", () => {
|
|
const links = extractLinksFromMessage("see https://a.example and http://b.test");
|
|
expect(links).toEqual(["https://a.example", "http://b.test"]);
|
|
});
|
|
|
|
it("dedupes links and enforces maxLinks", () => {
|
|
const links = extractLinksFromMessage("https://a.example https://a.example https://b.test", {
|
|
maxLinks: 1,
|
|
});
|
|
expect(links).toEqual(["https://a.example"]);
|
|
});
|
|
|
|
it("ignores markdown links", () => {
|
|
const links = extractLinksFromMessage("[doc](https://docs.example) https://bare.example");
|
|
expect(links).toEqual(["https://bare.example"]);
|
|
});
|
|
|
|
it("blocks 127.0.0.1", () => {
|
|
const links = extractLinksFromMessage("http://127.0.0.1/test https://ok.test");
|
|
expect(links).toEqual(["https://ok.test"]);
|
|
});
|
|
|
|
it("blocks localhost and common loopback addresses", () => {
|
|
expect(extractLinksFromMessage("http://localhost/secret")).toEqual([]);
|
|
expect(extractLinksFromMessage("http://foo.localhost/secret")).toEqual([]);
|
|
expect(extractLinksFromMessage("http://service.local/secret")).toEqual([]);
|
|
expect(extractLinksFromMessage("http://service.internal/secret")).toEqual([]);
|
|
expect(extractLinksFromMessage("http://0.0.0.0/secret")).toEqual([]);
|
|
expect(extractLinksFromMessage("http://[::1]/secret")).toEqual([]);
|
|
});
|
|
|
|
it("blocks private network ranges", () => {
|
|
expect(extractLinksFromMessage("http://10.0.0.1/internal")).toEqual([]);
|
|
expect(extractLinksFromMessage("http://172.16.0.1/internal")).toEqual([]);
|
|
expect(extractLinksFromMessage("http://192.168.1.1/internal")).toEqual([]);
|
|
});
|
|
|
|
it("blocks link-local and cloud metadata addresses", () => {
|
|
expect(extractLinksFromMessage("http://169.254.169.254/latest/meta-data/")).toEqual([]);
|
|
expect(extractLinksFromMessage("http://169.254.1.1/test")).toEqual([]);
|
|
expect(extractLinksFromMessage("http://metadata.google.internal/computeMetadata/v1/")).toEqual(
|
|
[],
|
|
);
|
|
});
|
|
|
|
it("blocks CGNAT range used by Tailscale", () => {
|
|
expect(extractLinksFromMessage("http://100.100.50.1/test")).toEqual([]);
|
|
});
|
|
|
|
it("blocks private and mapped IPv6 addresses", () => {
|
|
expect(extractLinksFromMessage("http://[::ffff:127.0.0.1]/secret")).toEqual([]);
|
|
expect(extractLinksFromMessage("http://[fe80::1]/secret")).toEqual([]);
|
|
expect(extractLinksFromMessage("http://[fc00::1]/secret")).toEqual([]);
|
|
});
|
|
|
|
it("allows legitimate public URLs", () => {
|
|
expect(extractLinksFromMessage("https://example.com/page")).toEqual([
|
|
"https://example.com/page",
|
|
]);
|
|
expect(extractLinksFromMessage("https://8.8.8.8/dns")).toEqual(["https://8.8.8.8/dns"]);
|
|
});
|
|
});
|