* docs: add ACP persistent binding experiment plan * docs: align ACP persistent binding spec to channel-local config * docs: scope Telegram ACP bindings to forum topics only * docs: lock bound /new and /reset behavior to in-place ACP reset * ACP: add persistent discord/telegram conversation bindings * ACP: fix persistent binding reuse and discord thread parent context * docs: document channel-specific persistent ACP bindings * ACP: split persistent bindings and share conversation id helpers * ACP: defer configured binding init until preflight passes * ACP: fix discord thread parent fallback and explicit disable inheritance * ACP: keep bound /new and /reset in-place * ACP: honor configured bindings in native command flows * ACP: avoid configured fallback after runtime bind failure * docs: refine ACP bindings experiment config examples * acp: cut over to typed top-level persistent bindings * ACP bindings: harden reset recovery and native command auth * Docs: add ACP bound command auth proposal * Tests: normalize i18n registry zh-CN assertion encoding * ACP bindings: address review findings for reset and fallback routing * ACP reset: gate hooks on success and preserve /new arguments * ACP bindings: fix auth and binding-priority review findings * Telegram ACP: gate ensure on auth and accepted messages * ACP bindings: fix session-key precedence and unavailable handling * ACP reset/native commands: honor fallback targets and abort on bootstrap failure * Config schema: validate ACP binding channel and Telegram topic IDs * Discord ACP: apply configured DM bindings to native commands * ACP reset tails: dispatch through ACP after command handling * ACP tails/native reset auth: fix target dispatch and restore full auth * ACP reset detection: fallback to active ACP keys for DM contexts * Tests: type runTurn mock input in ACP dispatch test * ACP: dedup binding route bootstrap and reset target resolution * reply: align ACP reset hooks with bound session key * docs: replace personal discord ids with placeholders * fix: add changelog entry for ACP persistent bindings (#34873) (thanks @dutifulbob) --------- Co-authored-by: Onur <2453968+osolmaz@users.noreply.github.com>
177 lines
5.2 KiB
TypeScript
177 lines
5.2 KiB
TypeScript
import { ChannelType } from "@buape/carbon";
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
const ensureConfiguredAcpBindingSessionMock = vi.hoisted(() => vi.fn());
|
|
const resolveConfiguredAcpBindingRecordMock = vi.hoisted(() => vi.fn());
|
|
|
|
vi.mock("../../acp/persistent-bindings.js", () => ({
|
|
ensureConfiguredAcpBindingSession: (...args: unknown[]) =>
|
|
ensureConfiguredAcpBindingSessionMock(...args),
|
|
resolveConfiguredAcpBindingRecord: (...args: unknown[]) =>
|
|
resolveConfiguredAcpBindingRecordMock(...args),
|
|
}));
|
|
|
|
import { __testing as sessionBindingTesting } from "../../infra/outbound/session-binding-service.js";
|
|
import { preflightDiscordMessage } from "./message-handler.preflight.js";
|
|
import { createNoopThreadBindingManager } from "./thread-bindings.js";
|
|
|
|
const GUILD_ID = "guild-1";
|
|
const CHANNEL_ID = "channel-1";
|
|
|
|
function createConfiguredDiscordBinding() {
|
|
return {
|
|
spec: {
|
|
channel: "discord",
|
|
accountId: "default",
|
|
conversationId: CHANNEL_ID,
|
|
agentId: "codex",
|
|
mode: "persistent",
|
|
},
|
|
record: {
|
|
bindingId: "config:acp:discord:default:channel-1",
|
|
targetSessionKey: "agent:codex:acp:binding:discord:default:abc123",
|
|
targetKind: "session",
|
|
conversation: {
|
|
channel: "discord",
|
|
accountId: "default",
|
|
conversationId: CHANNEL_ID,
|
|
},
|
|
status: "active",
|
|
boundAt: 0,
|
|
metadata: {
|
|
source: "config",
|
|
mode: "persistent",
|
|
agentId: "codex",
|
|
},
|
|
},
|
|
} as const;
|
|
}
|
|
|
|
function createBasePreflightParams(overrides?: Record<string, unknown>) {
|
|
const message = {
|
|
id: "m-1",
|
|
content: "<@bot-1> hello",
|
|
timestamp: new Date().toISOString(),
|
|
channelId: CHANNEL_ID,
|
|
attachments: [],
|
|
mentionedUsers: [{ id: "bot-1" }],
|
|
mentionedRoles: [],
|
|
mentionedEveryone: false,
|
|
author: {
|
|
id: "user-1",
|
|
bot: false,
|
|
username: "alice",
|
|
},
|
|
} as unknown as import("@buape/carbon").Message;
|
|
|
|
const client = {
|
|
fetchChannel: async (channelId: string) => {
|
|
if (channelId === CHANNEL_ID) {
|
|
return {
|
|
id: CHANNEL_ID,
|
|
type: ChannelType.GuildText,
|
|
name: "general",
|
|
};
|
|
}
|
|
return null;
|
|
},
|
|
} as unknown as import("@buape/carbon").Client;
|
|
|
|
return {
|
|
cfg: {
|
|
session: {
|
|
mainKey: "main",
|
|
scope: "per-sender",
|
|
},
|
|
} as import("../../config/config.js").OpenClawConfig,
|
|
discordConfig: {
|
|
allowBots: true,
|
|
} as NonNullable<import("../../config/config.js").OpenClawConfig["channels"]>["discord"],
|
|
accountId: "default",
|
|
token: "token",
|
|
runtime: {} as import("../../runtime.js").RuntimeEnv,
|
|
botUserId: "bot-1",
|
|
guildHistories: new Map(),
|
|
historyLimit: 0,
|
|
mediaMaxBytes: 1_000_000,
|
|
textLimit: 2_000,
|
|
replyToMode: "all",
|
|
dmEnabled: true,
|
|
groupDmEnabled: true,
|
|
ackReactionScope: "direct",
|
|
groupPolicy: "open",
|
|
threadBindings: createNoopThreadBindingManager("default"),
|
|
data: {
|
|
channel_id: CHANNEL_ID,
|
|
guild_id: GUILD_ID,
|
|
guild: {
|
|
id: GUILD_ID,
|
|
name: "Guild One",
|
|
},
|
|
author: message.author,
|
|
message,
|
|
} as unknown as import("./listeners.js").DiscordMessageEvent,
|
|
client,
|
|
...overrides,
|
|
} satisfies Parameters<typeof preflightDiscordMessage>[0];
|
|
}
|
|
|
|
describe("preflightDiscordMessage configured ACP bindings", () => {
|
|
beforeEach(() => {
|
|
sessionBindingTesting.resetSessionBindingAdaptersForTests();
|
|
ensureConfiguredAcpBindingSessionMock.mockReset();
|
|
resolveConfiguredAcpBindingRecordMock.mockReset();
|
|
resolveConfiguredAcpBindingRecordMock.mockReturnValue(createConfiguredDiscordBinding());
|
|
ensureConfiguredAcpBindingSessionMock.mockResolvedValue({
|
|
ok: true,
|
|
sessionKey: "agent:codex:acp:binding:discord:default:abc123",
|
|
});
|
|
});
|
|
|
|
it("does not initialize configured ACP bindings for rejected messages", async () => {
|
|
const result = await preflightDiscordMessage(
|
|
createBasePreflightParams({
|
|
guildEntries: {
|
|
[GUILD_ID]: {
|
|
id: GUILD_ID,
|
|
channels: {
|
|
[CHANNEL_ID]: {
|
|
allow: true,
|
|
enabled: false,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}),
|
|
);
|
|
|
|
expect(result).toBeNull();
|
|
expect(resolveConfiguredAcpBindingRecordMock).toHaveBeenCalledTimes(1);
|
|
expect(ensureConfiguredAcpBindingSessionMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("initializes configured ACP bindings only after preflight accepts the message", async () => {
|
|
const result = await preflightDiscordMessage(
|
|
createBasePreflightParams({
|
|
guildEntries: {
|
|
[GUILD_ID]: {
|
|
id: GUILD_ID,
|
|
channels: {
|
|
[CHANNEL_ID]: {
|
|
allow: true,
|
|
enabled: true,
|
|
requireMention: false,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}),
|
|
);
|
|
|
|
expect(result).not.toBeNull();
|
|
expect(resolveConfiguredAcpBindingRecordMock).toHaveBeenCalledTimes(1);
|
|
expect(ensureConfiguredAcpBindingSessionMock).toHaveBeenCalledTimes(1);
|
|
expect(result?.boundSessionKey).toBe("agent:codex:acp:binding:discord:default:abc123");
|
|
});
|
|
});
|