* fix(feishu): comprehensive reply mechanism fix — outbound replyToId forwarding + topic-aware reply targeting - Forward replyToId from ChannelOutboundContext through sendText/sendMedia to sendMessageFeishu/sendMarkdownCardFeishu/sendMediaFeishu, enabling reply-to-message via the message tool. - Fix group reply targeting: use ctx.messageId (triggering message) in normal groups to prevent silent topic thread creation (#32980). Preserve ctx.rootId targeting for topic-mode groups (group_topic/group_topic_sender) and groups with explicit replyInThread config. - Add regression tests for both fixes. Fixes #32980 Fixes #32958 Related #19784 * fix: normalize Feishu delivery.to before comparing with messaging tool targets - Add normalizeDeliveryTarget helper to strip user:/chat: prefixes for Feishu - Apply normalization in matchesMessagingToolDeliveryTarget before comparison - This ensures cron duplicate suppression works when session uses prefixed targets (user:ou_xxx) but messaging tool extract uses normalized bare IDs (ou_xxx) Fixes review comment on PR #32755 (cherry picked from commit fc20106f16ccc88a5f02e58922bb7b7999fe9dcd) * fix(feishu): catch thrown SDK errors for withdrawn reply targets The Feishu Lark SDK can throw exceptions (SDK errors with .code or AxiosErrors with .response.data.code) for withdrawn/deleted reply targets, in addition to returning error codes in the response object. Wrap reply calls in sendMessageFeishu and sendCardFeishu with try-catch to handle thrown withdrawn/not-found errors (230011, 231003) and fall back to client.im.message.create, matching the existing response-level fallback behavior. Also extract sendFallbackDirect helper to deduplicate the direct-send fallback block across both functions. Closes #33496 (cherry picked from commit ad0901aec103a2c52f186686cfaf5f8ba54b4a48) * feishu: forward outbound reply target context (cherry picked from commit c129a691fcf552a1cebe1e8a22ea8611ffc3b377) * feishu extension: tighten reply target fallback semantics (cherry picked from commit f85ec610f267020b66713c09e648ec004b2e26f1) * fix(feishu): align synthesized fallback typing and changelog attribution * test(feishu): cover group_topic_sender reply targeting --------- Co-authored-by: Xu Zimo <xuzimojimmy@163.com> Co-authored-by: Munem Hashmi <munem.hashmi@gmail.com> Co-authored-by: bmendonca3 <bmendonca3@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
180 lines
5.0 KiB
TypeScript
180 lines
5.0 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
const resolveFeishuSendTargetMock = vi.hoisted(() => vi.fn());
|
|
const resolveMarkdownTableModeMock = vi.hoisted(() => vi.fn(() => "preserve"));
|
|
const convertMarkdownTablesMock = vi.hoisted(() => vi.fn((text: string) => text));
|
|
|
|
vi.mock("./send-target.js", () => ({
|
|
resolveFeishuSendTarget: resolveFeishuSendTargetMock,
|
|
}));
|
|
|
|
vi.mock("./runtime.js", () => ({
|
|
getFeishuRuntime: () => ({
|
|
channel: {
|
|
text: {
|
|
resolveMarkdownTableMode: resolveMarkdownTableModeMock,
|
|
convertMarkdownTables: convertMarkdownTablesMock,
|
|
},
|
|
},
|
|
}),
|
|
}));
|
|
|
|
import { sendCardFeishu, sendMessageFeishu } from "./send.js";
|
|
|
|
describe("Feishu reply fallback for withdrawn/deleted targets", () => {
|
|
const replyMock = vi.fn();
|
|
const createMock = vi.fn();
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
resolveFeishuSendTargetMock.mockReturnValue({
|
|
client: {
|
|
im: {
|
|
message: {
|
|
reply: replyMock,
|
|
create: createMock,
|
|
},
|
|
},
|
|
},
|
|
receiveId: "ou_target",
|
|
receiveIdType: "open_id",
|
|
});
|
|
});
|
|
|
|
it("falls back to create for withdrawn post replies", async () => {
|
|
replyMock.mockResolvedValue({
|
|
code: 230011,
|
|
msg: "The message was withdrawn.",
|
|
});
|
|
createMock.mockResolvedValue({
|
|
code: 0,
|
|
data: { message_id: "om_new" },
|
|
});
|
|
|
|
const result = await sendMessageFeishu({
|
|
cfg: {} as never,
|
|
to: "user:ou_target",
|
|
text: "hello",
|
|
replyToMessageId: "om_parent",
|
|
});
|
|
|
|
expect(replyMock).toHaveBeenCalledTimes(1);
|
|
expect(createMock).toHaveBeenCalledTimes(1);
|
|
expect(result.messageId).toBe("om_new");
|
|
});
|
|
|
|
it("falls back to create for withdrawn card replies", async () => {
|
|
replyMock.mockResolvedValue({
|
|
code: 231003,
|
|
msg: "The message is not found",
|
|
});
|
|
createMock.mockResolvedValue({
|
|
code: 0,
|
|
data: { message_id: "om_card_new" },
|
|
});
|
|
|
|
const result = await sendCardFeishu({
|
|
cfg: {} as never,
|
|
to: "user:ou_target",
|
|
card: { schema: "2.0" },
|
|
replyToMessageId: "om_parent",
|
|
});
|
|
|
|
expect(replyMock).toHaveBeenCalledTimes(1);
|
|
expect(createMock).toHaveBeenCalledTimes(1);
|
|
expect(result.messageId).toBe("om_card_new");
|
|
});
|
|
|
|
it("still throws for non-withdrawn reply failures", async () => {
|
|
replyMock.mockResolvedValue({
|
|
code: 999999,
|
|
msg: "unknown failure",
|
|
});
|
|
|
|
await expect(
|
|
sendMessageFeishu({
|
|
cfg: {} as never,
|
|
to: "user:ou_target",
|
|
text: "hello",
|
|
replyToMessageId: "om_parent",
|
|
}),
|
|
).rejects.toThrow("Feishu reply failed");
|
|
|
|
expect(createMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("falls back to create when reply throws a withdrawn SDK error", async () => {
|
|
const sdkError = Object.assign(new Error("request failed"), { code: 230011 });
|
|
replyMock.mockRejectedValue(sdkError);
|
|
createMock.mockResolvedValue({
|
|
code: 0,
|
|
data: { message_id: "om_thrown_fallback" },
|
|
});
|
|
|
|
const result = await sendMessageFeishu({
|
|
cfg: {} as never,
|
|
to: "user:ou_target",
|
|
text: "hello",
|
|
replyToMessageId: "om_parent",
|
|
});
|
|
|
|
expect(replyMock).toHaveBeenCalledTimes(1);
|
|
expect(createMock).toHaveBeenCalledTimes(1);
|
|
expect(result.messageId).toBe("om_thrown_fallback");
|
|
});
|
|
|
|
it("falls back to create when card reply throws a not-found AxiosError", async () => {
|
|
const axiosError = Object.assign(new Error("Request failed"), {
|
|
response: { status: 200, data: { code: 231003, msg: "The message is not found" } },
|
|
});
|
|
replyMock.mockRejectedValue(axiosError);
|
|
createMock.mockResolvedValue({
|
|
code: 0,
|
|
data: { message_id: "om_axios_fallback" },
|
|
});
|
|
|
|
const result = await sendCardFeishu({
|
|
cfg: {} as never,
|
|
to: "user:ou_target",
|
|
card: { schema: "2.0" },
|
|
replyToMessageId: "om_parent",
|
|
});
|
|
|
|
expect(replyMock).toHaveBeenCalledTimes(1);
|
|
expect(createMock).toHaveBeenCalledTimes(1);
|
|
expect(result.messageId).toBe("om_axios_fallback");
|
|
});
|
|
|
|
it("re-throws non-withdrawn thrown errors for text messages", async () => {
|
|
const sdkError = Object.assign(new Error("rate limited"), { code: 99991400 });
|
|
replyMock.mockRejectedValue(sdkError);
|
|
|
|
await expect(
|
|
sendMessageFeishu({
|
|
cfg: {} as never,
|
|
to: "user:ou_target",
|
|
text: "hello",
|
|
replyToMessageId: "om_parent",
|
|
}),
|
|
).rejects.toThrow("rate limited");
|
|
|
|
expect(createMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("re-throws non-withdrawn thrown errors for card messages", async () => {
|
|
const sdkError = Object.assign(new Error("permission denied"), { code: 99991401 });
|
|
replyMock.mockRejectedValue(sdkError);
|
|
|
|
await expect(
|
|
sendCardFeishu({
|
|
cfg: {} as never,
|
|
to: "user:ou_target",
|
|
card: { schema: "2.0" },
|
|
replyToMessageId: "om_parent",
|
|
}),
|
|
).rejects.toThrow("permission denied");
|
|
|
|
expect(createMock).not.toHaveBeenCalled();
|
|
});
|
|
});
|