Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 14a3edb00572b20348f839bbafa56ca826cee362 Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky
486 lines
16 KiB
TypeScript
486 lines
16 KiB
TypeScript
import os from "node:os";
|
|
import path from "node:path";
|
|
import { describe, expect, it } from "vitest";
|
|
import { VoiceCallConfigSchema } from "./config.js";
|
|
import { CallManager } from "./manager.js";
|
|
import type { VoiceCallProvider } from "./providers/base.js";
|
|
import type {
|
|
HangupCallInput,
|
|
InitiateCallInput,
|
|
InitiateCallResult,
|
|
PlayTtsInput,
|
|
ProviderWebhookParseResult,
|
|
StartListeningInput,
|
|
StopListeningInput,
|
|
WebhookContext,
|
|
WebhookVerificationResult,
|
|
} from "./types.js";
|
|
|
|
class FakeProvider implements VoiceCallProvider {
|
|
readonly name = "plivo" as const;
|
|
readonly playTtsCalls: PlayTtsInput[] = [];
|
|
readonly hangupCalls: HangupCallInput[] = [];
|
|
readonly startListeningCalls: StartListeningInput[] = [];
|
|
readonly stopListeningCalls: StopListeningInput[] = [];
|
|
|
|
verifyWebhook(_ctx: WebhookContext): WebhookVerificationResult {
|
|
return { ok: true };
|
|
}
|
|
parseWebhookEvent(_ctx: WebhookContext): ProviderWebhookParseResult {
|
|
return { events: [], statusCode: 200 };
|
|
}
|
|
async initiateCall(_input: InitiateCallInput): Promise<InitiateCallResult> {
|
|
return { providerCallId: "request-uuid", status: "initiated" };
|
|
}
|
|
async hangupCall(input: HangupCallInput): Promise<void> {
|
|
this.hangupCalls.push(input);
|
|
}
|
|
async playTts(input: PlayTtsInput): Promise<void> {
|
|
this.playTtsCalls.push(input);
|
|
}
|
|
async startListening(input: StartListeningInput): Promise<void> {
|
|
this.startListeningCalls.push(input);
|
|
}
|
|
async stopListening(input: StopListeningInput): Promise<void> {
|
|
this.stopListeningCalls.push(input);
|
|
}
|
|
}
|
|
|
|
describe("CallManager", () => {
|
|
it("upgrades providerCallId mapping when provider ID changes", async () => {
|
|
const config = VoiceCallConfigSchema.parse({
|
|
enabled: true,
|
|
provider: "plivo",
|
|
fromNumber: "+15550000000",
|
|
});
|
|
|
|
const storePath = path.join(os.tmpdir(), `openclaw-voice-call-test-${Date.now()}`);
|
|
const manager = new CallManager(config, storePath);
|
|
manager.initialize(new FakeProvider(), "https://example.com/voice/webhook");
|
|
|
|
const { callId, success, error } = await manager.initiateCall("+15550000001");
|
|
expect(success).toBe(true);
|
|
expect(error).toBeUndefined();
|
|
|
|
// The provider returned a request UUID as the initial providerCallId.
|
|
expect(manager.getCall(callId)?.providerCallId).toBe("request-uuid");
|
|
expect(manager.getCallByProviderCallId("request-uuid")?.callId).toBe(callId);
|
|
|
|
// Provider later reports the actual call UUID.
|
|
manager.processEvent({
|
|
id: "evt-1",
|
|
type: "call.answered",
|
|
callId,
|
|
providerCallId: "call-uuid",
|
|
timestamp: Date.now(),
|
|
});
|
|
|
|
expect(manager.getCall(callId)?.providerCallId).toBe("call-uuid");
|
|
expect(manager.getCallByProviderCallId("call-uuid")?.callId).toBe(callId);
|
|
expect(manager.getCallByProviderCallId("request-uuid")).toBeUndefined();
|
|
});
|
|
|
|
it("speaks initial message on answered for notify mode (non-Twilio)", async () => {
|
|
const config = VoiceCallConfigSchema.parse({
|
|
enabled: true,
|
|
provider: "plivo",
|
|
fromNumber: "+15550000000",
|
|
});
|
|
|
|
const storePath = path.join(os.tmpdir(), `openclaw-voice-call-test-${Date.now()}`);
|
|
const provider = new FakeProvider();
|
|
const manager = new CallManager(config, storePath);
|
|
manager.initialize(provider, "https://example.com/voice/webhook");
|
|
|
|
const { callId, success } = await manager.initiateCall("+15550000002", undefined, {
|
|
message: "Hello there",
|
|
mode: "notify",
|
|
});
|
|
expect(success).toBe(true);
|
|
|
|
manager.processEvent({
|
|
id: "evt-2",
|
|
type: "call.answered",
|
|
callId,
|
|
providerCallId: "call-uuid",
|
|
timestamp: Date.now(),
|
|
});
|
|
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
|
|
expect(provider.playTtsCalls).toHaveLength(1);
|
|
expect(provider.playTtsCalls[0]?.text).toBe("Hello there");
|
|
});
|
|
|
|
it("rejects inbound calls with missing caller ID when allowlist enabled", () => {
|
|
const config = VoiceCallConfigSchema.parse({
|
|
enabled: true,
|
|
provider: "plivo",
|
|
fromNumber: "+15550000000",
|
|
inboundPolicy: "allowlist",
|
|
allowFrom: ["+15550001234"],
|
|
});
|
|
|
|
const storePath = path.join(os.tmpdir(), `openclaw-voice-call-test-${Date.now()}`);
|
|
const provider = new FakeProvider();
|
|
const manager = new CallManager(config, storePath);
|
|
manager.initialize(provider, "https://example.com/voice/webhook");
|
|
|
|
manager.processEvent({
|
|
id: "evt-allowlist-missing",
|
|
type: "call.initiated",
|
|
callId: "call-missing",
|
|
providerCallId: "provider-missing",
|
|
timestamp: Date.now(),
|
|
direction: "inbound",
|
|
to: "+15550000000",
|
|
});
|
|
|
|
expect(manager.getCallByProviderCallId("provider-missing")).toBeUndefined();
|
|
expect(provider.hangupCalls).toHaveLength(1);
|
|
expect(provider.hangupCalls[0]?.providerCallId).toBe("provider-missing");
|
|
});
|
|
|
|
it("rejects inbound calls with anonymous caller ID when allowlist enabled", () => {
|
|
const config = VoiceCallConfigSchema.parse({
|
|
enabled: true,
|
|
provider: "plivo",
|
|
fromNumber: "+15550000000",
|
|
inboundPolicy: "allowlist",
|
|
allowFrom: ["+15550001234"],
|
|
});
|
|
|
|
const storePath = path.join(os.tmpdir(), `openclaw-voice-call-test-${Date.now()}`);
|
|
const provider = new FakeProvider();
|
|
const manager = new CallManager(config, storePath);
|
|
manager.initialize(provider, "https://example.com/voice/webhook");
|
|
|
|
manager.processEvent({
|
|
id: "evt-allowlist-anon",
|
|
type: "call.initiated",
|
|
callId: "call-anon",
|
|
providerCallId: "provider-anon",
|
|
timestamp: Date.now(),
|
|
direction: "inbound",
|
|
from: "anonymous",
|
|
to: "+15550000000",
|
|
});
|
|
|
|
expect(manager.getCallByProviderCallId("provider-anon")).toBeUndefined();
|
|
expect(provider.hangupCalls).toHaveLength(1);
|
|
expect(provider.hangupCalls[0]?.providerCallId).toBe("provider-anon");
|
|
});
|
|
|
|
it("rejects inbound calls that only match allowlist suffixes", () => {
|
|
const config = VoiceCallConfigSchema.parse({
|
|
enabled: true,
|
|
provider: "plivo",
|
|
fromNumber: "+15550000000",
|
|
inboundPolicy: "allowlist",
|
|
allowFrom: ["+15550001234"],
|
|
});
|
|
|
|
const storePath = path.join(os.tmpdir(), `openclaw-voice-call-test-${Date.now()}`);
|
|
const provider = new FakeProvider();
|
|
const manager = new CallManager(config, storePath);
|
|
manager.initialize(provider, "https://example.com/voice/webhook");
|
|
|
|
manager.processEvent({
|
|
id: "evt-allowlist-suffix",
|
|
type: "call.initiated",
|
|
callId: "call-suffix",
|
|
providerCallId: "provider-suffix",
|
|
timestamp: Date.now(),
|
|
direction: "inbound",
|
|
from: "+99915550001234",
|
|
to: "+15550000000",
|
|
});
|
|
|
|
expect(manager.getCallByProviderCallId("provider-suffix")).toBeUndefined();
|
|
expect(provider.hangupCalls).toHaveLength(1);
|
|
expect(provider.hangupCalls[0]?.providerCallId).toBe("provider-suffix");
|
|
});
|
|
|
|
it("rejects duplicate inbound events with a single hangup call", () => {
|
|
const config = VoiceCallConfigSchema.parse({
|
|
enabled: true,
|
|
provider: "plivo",
|
|
fromNumber: "+15550000000",
|
|
inboundPolicy: "disabled",
|
|
});
|
|
|
|
const storePath = path.join(os.tmpdir(), `openclaw-voice-call-test-${Date.now()}`);
|
|
const provider = new FakeProvider();
|
|
const manager = new CallManager(config, storePath);
|
|
manager.initialize(provider, "https://example.com/voice/webhook");
|
|
|
|
manager.processEvent({
|
|
id: "evt-reject-init",
|
|
type: "call.initiated",
|
|
callId: "provider-dup",
|
|
providerCallId: "provider-dup",
|
|
timestamp: Date.now(),
|
|
direction: "inbound",
|
|
from: "+15552222222",
|
|
to: "+15550000000",
|
|
});
|
|
|
|
manager.processEvent({
|
|
id: "evt-reject-ring",
|
|
type: "call.ringing",
|
|
callId: "provider-dup",
|
|
providerCallId: "provider-dup",
|
|
timestamp: Date.now(),
|
|
direction: "inbound",
|
|
from: "+15552222222",
|
|
to: "+15550000000",
|
|
});
|
|
|
|
expect(manager.getCallByProviderCallId("provider-dup")).toBeUndefined();
|
|
expect(provider.hangupCalls).toHaveLength(1);
|
|
expect(provider.hangupCalls[0]?.providerCallId).toBe("provider-dup");
|
|
});
|
|
|
|
it("accepts inbound calls that exactly match the allowlist", () => {
|
|
const config = VoiceCallConfigSchema.parse({
|
|
enabled: true,
|
|
provider: "plivo",
|
|
fromNumber: "+15550000000",
|
|
inboundPolicy: "allowlist",
|
|
allowFrom: ["+15550001234"],
|
|
});
|
|
|
|
const storePath = path.join(os.tmpdir(), `openclaw-voice-call-test-${Date.now()}`);
|
|
const manager = new CallManager(config, storePath);
|
|
manager.initialize(new FakeProvider(), "https://example.com/voice/webhook");
|
|
|
|
manager.processEvent({
|
|
id: "evt-allowlist-exact",
|
|
type: "call.initiated",
|
|
callId: "call-exact",
|
|
providerCallId: "provider-exact",
|
|
timestamp: Date.now(),
|
|
direction: "inbound",
|
|
from: "+15550001234",
|
|
to: "+15550000000",
|
|
});
|
|
|
|
expect(manager.getCallByProviderCallId("provider-exact")).toBeDefined();
|
|
});
|
|
|
|
it("completes a closed-loop turn without live audio", async () => {
|
|
const config = VoiceCallConfigSchema.parse({
|
|
enabled: true,
|
|
provider: "plivo",
|
|
fromNumber: "+15550000000",
|
|
transcriptTimeoutMs: 5000,
|
|
});
|
|
|
|
const storePath = path.join(os.tmpdir(), `openclaw-voice-call-test-${Date.now()}`);
|
|
const provider = new FakeProvider();
|
|
const manager = new CallManager(config, storePath);
|
|
manager.initialize(provider, "https://example.com/voice/webhook");
|
|
|
|
const started = await manager.initiateCall("+15550000003");
|
|
expect(started.success).toBe(true);
|
|
|
|
manager.processEvent({
|
|
id: "evt-closed-loop-answered",
|
|
type: "call.answered",
|
|
callId: started.callId,
|
|
providerCallId: "request-uuid",
|
|
timestamp: Date.now(),
|
|
});
|
|
|
|
const turnPromise = manager.continueCall(started.callId, "How can I help?");
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
|
|
manager.processEvent({
|
|
id: "evt-closed-loop-speech",
|
|
type: "call.speech",
|
|
callId: started.callId,
|
|
providerCallId: "request-uuid",
|
|
timestamp: Date.now(),
|
|
transcript: "Please check status",
|
|
isFinal: true,
|
|
});
|
|
|
|
const turn = await turnPromise;
|
|
expect(turn.success).toBe(true);
|
|
expect(turn.transcript).toBe("Please check status");
|
|
expect(provider.startListeningCalls).toHaveLength(1);
|
|
expect(provider.stopListeningCalls).toHaveLength(1);
|
|
|
|
const call = manager.getCall(started.callId);
|
|
expect(call?.transcript.map((entry) => entry.text)).toEqual([
|
|
"How can I help?",
|
|
"Please check status",
|
|
]);
|
|
const metadata = (call?.metadata ?? {}) as Record<string, unknown>;
|
|
expect(typeof metadata.lastTurnLatencyMs).toBe("number");
|
|
expect(typeof metadata.lastTurnListenWaitMs).toBe("number");
|
|
expect(metadata.turnCount).toBe(1);
|
|
});
|
|
|
|
it("rejects overlapping continueCall requests for the same call", async () => {
|
|
const config = VoiceCallConfigSchema.parse({
|
|
enabled: true,
|
|
provider: "plivo",
|
|
fromNumber: "+15550000000",
|
|
transcriptTimeoutMs: 5000,
|
|
});
|
|
|
|
const storePath = path.join(os.tmpdir(), `openclaw-voice-call-test-${Date.now()}`);
|
|
const provider = new FakeProvider();
|
|
const manager = new CallManager(config, storePath);
|
|
manager.initialize(provider, "https://example.com/voice/webhook");
|
|
|
|
const started = await manager.initiateCall("+15550000004");
|
|
expect(started.success).toBe(true);
|
|
|
|
manager.processEvent({
|
|
id: "evt-overlap-answered",
|
|
type: "call.answered",
|
|
callId: started.callId,
|
|
providerCallId: "request-uuid",
|
|
timestamp: Date.now(),
|
|
});
|
|
|
|
const first = manager.continueCall(started.callId, "First prompt");
|
|
const second = await manager.continueCall(started.callId, "Second prompt");
|
|
expect(second.success).toBe(false);
|
|
expect(second.error).toBe("Already waiting for transcript");
|
|
|
|
manager.processEvent({
|
|
id: "evt-overlap-speech",
|
|
type: "call.speech",
|
|
callId: started.callId,
|
|
providerCallId: "request-uuid",
|
|
timestamp: Date.now(),
|
|
transcript: "Done",
|
|
isFinal: true,
|
|
});
|
|
|
|
const firstResult = await first;
|
|
expect(firstResult.success).toBe(true);
|
|
expect(firstResult.transcript).toBe("Done");
|
|
expect(provider.startListeningCalls).toHaveLength(1);
|
|
expect(provider.stopListeningCalls).toHaveLength(1);
|
|
});
|
|
|
|
it("tracks latency metadata across multiple closed-loop turns", async () => {
|
|
const config = VoiceCallConfigSchema.parse({
|
|
enabled: true,
|
|
provider: "plivo",
|
|
fromNumber: "+15550000000",
|
|
transcriptTimeoutMs: 5000,
|
|
});
|
|
|
|
const storePath = path.join(os.tmpdir(), `openclaw-voice-call-test-${Date.now()}`);
|
|
const provider = new FakeProvider();
|
|
const manager = new CallManager(config, storePath);
|
|
manager.initialize(provider, "https://example.com/voice/webhook");
|
|
|
|
const started = await manager.initiateCall("+15550000005");
|
|
expect(started.success).toBe(true);
|
|
|
|
manager.processEvent({
|
|
id: "evt-multi-answered",
|
|
type: "call.answered",
|
|
callId: started.callId,
|
|
providerCallId: "request-uuid",
|
|
timestamp: Date.now(),
|
|
});
|
|
|
|
const firstTurn = manager.continueCall(started.callId, "First question");
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
manager.processEvent({
|
|
id: "evt-multi-speech-1",
|
|
type: "call.speech",
|
|
callId: started.callId,
|
|
providerCallId: "request-uuid",
|
|
timestamp: Date.now(),
|
|
transcript: "First answer",
|
|
isFinal: true,
|
|
});
|
|
await firstTurn;
|
|
|
|
const secondTurn = manager.continueCall(started.callId, "Second question");
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
manager.processEvent({
|
|
id: "evt-multi-speech-2",
|
|
type: "call.speech",
|
|
callId: started.callId,
|
|
providerCallId: "request-uuid",
|
|
timestamp: Date.now(),
|
|
transcript: "Second answer",
|
|
isFinal: true,
|
|
});
|
|
const secondResult = await secondTurn;
|
|
|
|
expect(secondResult.success).toBe(true);
|
|
|
|
const call = manager.getCall(started.callId);
|
|
expect(call?.transcript.map((entry) => entry.text)).toEqual([
|
|
"First question",
|
|
"First answer",
|
|
"Second question",
|
|
"Second answer",
|
|
]);
|
|
const metadata = (call?.metadata ?? {}) as Record<string, unknown>;
|
|
expect(metadata.turnCount).toBe(2);
|
|
expect(typeof metadata.lastTurnLatencyMs).toBe("number");
|
|
expect(typeof metadata.lastTurnListenWaitMs).toBe("number");
|
|
expect(provider.startListeningCalls).toHaveLength(2);
|
|
expect(provider.stopListeningCalls).toHaveLength(2);
|
|
});
|
|
|
|
it("handles repeated closed-loop turns without waiter churn", async () => {
|
|
const config = VoiceCallConfigSchema.parse({
|
|
enabled: true,
|
|
provider: "plivo",
|
|
fromNumber: "+15550000000",
|
|
transcriptTimeoutMs: 5000,
|
|
});
|
|
|
|
const storePath = path.join(os.tmpdir(), `openclaw-voice-call-test-${Date.now()}`);
|
|
const provider = new FakeProvider();
|
|
const manager = new CallManager(config, storePath);
|
|
manager.initialize(provider, "https://example.com/voice/webhook");
|
|
|
|
const started = await manager.initiateCall("+15550000006");
|
|
expect(started.success).toBe(true);
|
|
|
|
manager.processEvent({
|
|
id: "evt-loop-answered",
|
|
type: "call.answered",
|
|
callId: started.callId,
|
|
providerCallId: "request-uuid",
|
|
timestamp: Date.now(),
|
|
});
|
|
|
|
for (let i = 1; i <= 5; i++) {
|
|
const turnPromise = manager.continueCall(started.callId, `Prompt ${i}`);
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
manager.processEvent({
|
|
id: `evt-loop-speech-${i}`,
|
|
type: "call.speech",
|
|
callId: started.callId,
|
|
providerCallId: "request-uuid",
|
|
timestamp: Date.now(),
|
|
transcript: `Answer ${i}`,
|
|
isFinal: true,
|
|
});
|
|
const result = await turnPromise;
|
|
expect(result.success).toBe(true);
|
|
expect(result.transcript).toBe(`Answer ${i}`);
|
|
}
|
|
|
|
const call = manager.getCall(started.callId);
|
|
const metadata = (call?.metadata ?? {}) as Record<string, unknown>;
|
|
expect(metadata.turnCount).toBe(5);
|
|
expect(provider.startListeningCalls).toHaveLength(5);
|
|
expect(provider.stopListeningCalls).toHaveLength(5);
|
|
});
|
|
});
|