From cdb92494d1ddd4c3f36e1d66f448fc999c35f7c3 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Sat, 21 Feb 2026 20:02:10 +0000
Subject: [PATCH] test(cli): dedupe inspect runner and cover
 snapshot/screenshot mode defaults

---
 src/cli/browser-cli-inspect.test.ts | 33 +++++++++++++++++++++++++++--
 1 file changed, 31 insertions(+), 2 deletions(-)

diff --git a/src/cli/browser-cli-inspect.test.ts b/src/cli/browser-cli-inspect.test.ts
index 4d254b1cd..14a0b2f3b 100644
--- a/src/cli/browser-cli-inspect.test.ts
+++ b/src/cli/browser-cli-inspect.test.ts
@@ -65,16 +65,20 @@ type SnapshotDefaultsCase = {
 };
 
 describe("browser cli snapshot defaults", () => {
-  const runSnapshot = async (args: string[]) => {
+  const runBrowserInspect = async (args: string[], withJson = false) => {
     const program = new Command();
     const browser = program.command("browser").option("--json", "JSON output", false);
     registerBrowserInspectCommands(browser, () => ({}));
-    await program.parseAsync(["browser", "snapshot", ...args], { from: "user" });
+    await program.parseAsync(withJson ? ["browser", "--json", ...args] : ["browser", ...args], {
+      from: "user",
+    });
 
     const [, params] = sharedMocks.callBrowserRequest.mock.calls.at(-1) ?? [];
     return params as { path?: string; query?: Record<string, unknown> } | undefined;
   };
 
+  const runSnapshot = async (args: string[]) => await runBrowserInspect(["snapshot", ...args]);
+
   beforeAll(async () => {
     ({ registerBrowserInspectCommands } = await import("./browser-cli-inspect.js"));
   });
@@ -121,4 +125,29 @@ describe("browser cli snapshot defaults", () => {
       });
     }
   });
+
+  it("does not set mode when config defaults are absent", async () => {
+    configMocks.loadConfig.mockReturnValue({ browser: {} });
+    const params = await runSnapshot([]);
+    expect((params?.query as { mode?: unknown } | undefined)?.mode).toBeUndefined();
+  });
+
+  it("applies explicit efficient mode without config defaults", async () => {
+    configMocks.loadConfig.mockReturnValue({ browser: {} });
+    const params = await runSnapshot(["--efficient"]);
+    expect(params?.query).toMatchObject({
+      format: "ai",
+      mode: "efficient",
+    });
+  });
+
+  it("sends screenshot request with trimmed target id and jpeg type", async () => {
+    const params = await runBrowserInspect(["screenshot", " tab-1 ", "--type", "jpeg"], true);
+    expect(params?.path).toBe("/screenshot");
+    expect((params as { body?: Record<string, unknown> } | undefined)?.body).toMatchObject({
+      targetId: "tab-1",
+      type: "jpeg",
+      fullPage: false,
+    });
+  });
 });