Agents/Tools: preflight exec script files for shell var injection (#18457)
* fix(agents): don't force store=true for codex responses * test: stabilize respawn + subagent usage assertions * Agents/Tools: preflight exec to detect shell variable injection in scripts * Changelog: fix merge marker formatting
This commit is contained in:
65
src/agents/bash-tools.exec.script-preflight.test.ts
Normal file
65
src/agents/bash-tools.exec.script-preflight.test.ts
Normal file
@@ -0,0 +1,65 @@
|
||||
import fs from "node:fs/promises";
|
||||
import os from "node:os";
|
||||
import path from "node:path";
|
||||
import { describe, expect, it } from "vitest";
|
||||
|
||||
const isWin = process.platform === "win32";
|
||||
|
||||
describe("exec script preflight", () => {
|
||||
it("blocks shell env var injection tokens in python scripts before execution", async () => {
|
||||
if (isWin) {
|
||||
return;
|
||||
}
|
||||
|
||||
const tmp = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-exec-preflight-"));
|
||||
const pyPath = path.join(tmp, "bad.py");
|
||||
|
||||
await fs.writeFile(
|
||||
pyPath,
|
||||
[
|
||||
"import json",
|
||||
"# model accidentally wrote shell syntax:",
|
||||
"payload = $DM_JSON",
|
||||
"print(payload)",
|
||||
].join("\n"),
|
||||
"utf-8",
|
||||
);
|
||||
|
||||
const { createExecTool } = await import("./bash-tools.exec.js");
|
||||
const tool = createExecTool({ host: "gateway", security: "full", ask: "off" });
|
||||
|
||||
await expect(
|
||||
tool.execute("call1", {
|
||||
command: "python bad.py",
|
||||
workdir: tmp,
|
||||
}),
|
||||
).rejects.toThrow(/exec preflight: detected likely shell variable injection \(\$DM_JSON\)/);
|
||||
});
|
||||
|
||||
it("blocks obvious shell-as-js output before node execution", async () => {
|
||||
if (isWin) {
|
||||
return;
|
||||
}
|
||||
|
||||
const tmp = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-exec-preflight-"));
|
||||
const jsPath = path.join(tmp, "bad.js");
|
||||
|
||||
await fs.writeFile(
|
||||
jsPath,
|
||||
['NODE "$TMPDIR/hot.json"', "console.log('hi')"].join("\n"),
|
||||
"utf-8",
|
||||
);
|
||||
|
||||
const { createExecTool } = await import("./bash-tools.exec.js");
|
||||
const tool = createExecTool({ host: "gateway", security: "full", ask: "off" });
|
||||
|
||||
await expect(
|
||||
tool.execute("call1", {
|
||||
command: "node bad.js",
|
||||
workdir: tmp,
|
||||
}),
|
||||
).rejects.toThrow(
|
||||
/exec preflight: (detected likely shell variable injection|JS file starts with shell syntax)/,
|
||||
);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user