test: dedupe and optimize test suites

src/cli/program/command-registry.test.ts

@@ -39,6 +39,18 @@ const testProgramContext: ProgramContext = {
 };
 
 describe("command-registry", () => {
+  const createProgram = () => new Command();
+
+  const withProcessArgv = async (argv: string[], run: () => Promise<void>) => {
+    const prevArgv = process.argv;
+    process.argv = argv;
+    try {
+      await run();
+    } finally {
+      process.argv = prevArgv;
+    }
+  };
+
   it("includes both agent and agents in core CLI command names", () => {
     const names = getCoreCliCommandNames();
     expect(names).toContain("agent");
@@ -46,7 +58,7 @@ describe("command-registry", () => {
   });
 
   it("registerCoreCliByName resolves agents to the agent entry", async () => {
-    const program = new Command();
+    const program = createProgram();
     const found = await registerCoreCliByName(program, testProgramContext, "agents");
     expect(found).toBe(true);
     const agentsCmd = program.commands.find((c) => c.name() === "agents");
@@ -57,20 +69,20 @@ describe("command-registry", () => {
   });
 
   it("registerCoreCliByName returns false for unknown commands", async () => {
-    const program = new Command();
+    const program = createProgram();
     const found = await registerCoreCliByName(program, testProgramContext, "nonexistent");
     expect(found).toBe(false);
   });
 
   it("registers doctor placeholder for doctor primary command", () => {
-    const program = new Command();
+    const program = createProgram();
     registerCoreCliCommands(program, testProgramContext, ["node", "openclaw", "doctor"]);
 
     expect(program.commands.map((command) => command.name())).toEqual(["doctor"]);
   });
 
   it("treats maintenance commands as top-level builtins", async () => {
-    const program = new Command();
+    const program = createProgram();
 
     expect(await registerCoreCliByName(program, testProgramContext, "doctor")).toBe(true);
 
@@ -83,17 +95,12 @@ describe("command-registry", () => {
   });
 
   it("registers grouped core entry placeholders without duplicate command errors", async () => {
-    const program = new Command();
+    const program = createProgram();
     registerCoreCliCommands(program, testProgramContext, ["node", "openclaw", "vitest"]);
-
-    const prevArgv = process.argv;
-    process.argv = ["node", "openclaw", "status"];
-    try {
-      program.exitOverride();
+    program.exitOverride();
+    await withProcessArgv(["node", "openclaw", "status"], async () => {
       await program.parseAsync(["node", "openclaw", "status"]);
-    } finally {
-      process.argv = prevArgv;
-    }
+    });
 
     const names = program.commands.map((command) => command.name());
     expect(names).toContain("status");