CLI: fix lazy maintenance command registration (#16374)

Merged via /review-pr -> /prepare-pr -> /merge-pr.

Prepared head SHA: 29d7cca6742bc33793fe8a38df456214fef0da3d
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Reviewed-by: @gumadeiras
This commit is contained in:
Gustavo Madeira Santana
2026-02-14 13:10:10 -05:00
committed by GitHub
parent 5ba72bd9bf
commit 7d4078c704
3 changed files with 41 additions and 6 deletions

View File

@@ -1,10 +1,16 @@
import { Command } from "commander";
import { describe, expect, it } from "vitest";
import type { ProgramContext } from "./context.js";
import { getCoreCliCommandNames, registerCoreCliByName } from "./command-registry.js";
import {
getCoreCliCommandNames,
registerCoreCliByName,
registerCoreCliCommands,
} from "./command-registry.js";
const stubCtx: ProgramContext = {
const testProgramContext: ProgramContext = {
programVersion: "0.0.0-test",
channelOptions: [],
messageChannelOptions: "",
agentChannelOptions: "web",
};
@@ -17,18 +23,38 @@ describe("command-registry", () => {
it("registerCoreCliByName resolves agents to the agent entry", async () => {
const program = new Command();
const found = await registerCoreCliByName(program, stubCtx, "agents");
const found = await registerCoreCliByName(program, testProgramContext, "agents");
expect(found).toBe(true);
const agentsCmd = program.commands.find((c) => c.name() === "agents");
expect(agentsCmd).toBeDefined();
// The registrar also installs the singular "agent" command from the same entry
// The registrar also installs the singular "agent" command from the same entry.
const agentCmd = program.commands.find((c) => c.name() === "agent");
expect(agentCmd).toBeDefined();
});
it("registerCoreCliByName returns false for unknown commands", async () => {
const program = new Command();
const found = await registerCoreCliByName(program, stubCtx, "nonexistent");
const found = await registerCoreCliByName(program, testProgramContext, "nonexistent");
expect(found).toBe(false);
});
it("registers doctor placeholder for doctor primary command", () => {
const program = new Command();
registerCoreCliCommands(program, testProgramContext, ["node", "openclaw", "doctor"]);
expect(program.commands.map((command) => command.name())).toEqual(["doctor"]);
});
it("treats maintenance commands as top-level builtins", async () => {
const program = new Command();
expect(await registerCoreCliByName(program, testProgramContext, "doctor")).toBe(true);
const names = getCoreCliCommandNames();
expect(names).toContain("doctor");
expect(names).toContain("dashboard");
expect(names).toContain("reset");
expect(names).toContain("uninstall");
expect(names).not.toContain("maintenance");
});
});